Skip to content
This repository was archived by the owner on Jan 13, 2022. It is now read-only.

added support for PHP8 #1212

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from
Open

added support for PHP8 #1212

wants to merge 3 commits into from

Conversation

brainexe
Copy link

I added support for PHP8, as it's required soonish.
This require some major PHPunit upgrades to version 9.*. This kicks out PHP 7.0 and below (e.g. by needed return typehints).
But there is no PHP7.0 support since years...

manay PHPunit BCs...
manay PHPunit BCs...
manay PHPunit BCs...
@limonte
Copy link

limonte commented Jan 11, 2021

@brainexe your PR most probably won't be merged because this repo is not maintained anymore. Would you mind to fork it and publish this change so folks can use your fork with PHP 8?

@jeversen
Copy link

jeversen commented Feb 6, 2021

@brainexe like @limonte says, it would be great if you could make your fork public so people can use it with PHP8 :)

@brainexe
Copy link
Author

brainexe commented Feb 6, 2021

sorry, right now I'm not willing to maintain a fork. But feel free to use the current version from https://github.com/brainexe/php-graph-sdk/tree/php8 (you can use it directly or create another fork out of it). I'll keep my version as it is

@spekulatius
Copy link

sorry, right now I'm not willing to maintain a fork. But feel free to use the current version from https://github.com/brainexe/php-graph-sdk/tree/php8 (you can use it directly or create another fork out of it). I'll keep my version as it is

Totally understandable. Maintaining a fork of this size isn't something to take lightly. Maybe someone at @facebook is able to get this moving? Sounds like there is plenty of interest in PHP8 for the SDK...

@brainexe
Copy link
Author

@nickdnk thx, look fine 👍
I am not planning any further changes as I became a father recently and have less dev time than I had hoped 😅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants